Copilot commented on code in PR #17091:
URL: https://github.com/apache/pinot/pull/17091#discussion_r2467637990
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/tpch/TblToAvroMultiValue.java:
##########
@@ -43,82 +42,82 @@ public class TblToAvroMultiValue {
private static final String STRING_TYPE = "string";
private static final String FOLDER_PATH =
"/Users/saurabh.dubey/Documents/workspace/stuff/tpch/data/s001/";
private static final String TBL_FILE_SUFFIX = ".tbl";
- private static final Map<String, String[]> TABLE_NAME_FIELDS_MAP =
ImmutableMap.<String, String[]>builder().
+ private static final Map<String, String[]> TABLE_NAME_FIELDS_MAP = Map.of(
Review Comment:
Map.of() only supports up to 10 key-value pairs. This map has 8 entries
(customer, lineitem, nation, orders, part, partsupp, region, supplier), which
is within the limit. However, if this was intended to be extensible or if there
are plans to add more entries in the future, consider using Map.ofEntries()
instead to avoid hitting the 10-entry limit.
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/tpch/TblToAvro.java:
##########
@@ -45,17 +44,17 @@ public final class TblToAvro {
private static final String STRING_TYPE = "string";
private static final String FOLDER_PATH =
"/Users/haitaozhang/Downloads/TPC-H-V3.0.1/dbgen/";
private static final String TBL_FILE_SUFFIX = ".tbl";
- private static final Map<String, String[]> TABLE_NAME_FIELDS_MAP =
ImmutableMap.<String, String[]>builder().
+ private static final Map<String, String[]> TABLE_NAME_FIELDS_MAP = Map.of(
Review Comment:
Map.of() only supports up to 10 key-value pairs. This map has 8 entries
(customer, lineitem, nation, orders, part, partsupp, region, supplier), which
is within the limit. However, if this was intended to be extensible or if there
are plans to add more entries in the future, consider using Map.ofEntries()
instead to avoid hitting the 10-entry limit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
