Copilot commented on code in PR #17072:
URL: https://github.com/apache/pinot/pull/17072#discussion_r2467168174
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/builder/TableConfigBuilder.java:
##########
@@ -54,7 +54,6 @@
public class TableConfigBuilder {
- private static final String DEFAULT_SEGMENT_PUSH_TYPE = "APPEND";
private static final String REFRESH_SEGMENT_PUSH_TYPE = "REFRESH";
Review Comment:
[nitpick] Consider defining a constant for 'APPEND' similar to
`REFRESH_SEGMENT_PUSH_TYPE`. This would maintain consistency in the codebase
and make future changes easier. For example: `private static final String
APPEND_SEGMENT_PUSH_TYPE = \"APPEND\";`
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/builder/TableConfigBuilder.java:
##########
@@ -76,9 +75,8 @@ public class TableConfigBuilder {
@Deprecated
private String _segmentPushFrequency;
- // TODO: Remove 'DEFAULT_SEGMENT_PUSH_TYPE' in the future major release.
@Deprecated
- private String _segmentPushType = DEFAULT_SEGMENT_PUSH_TYPE;
+ private String _segmentPushType = "APPEND";
Review Comment:
The hardcoded string literal 'APPEND' appears multiple times (lines 79 and
208). Consider extracting this into a constant to avoid magic strings and
ensure consistency across all usages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
