Akanksha-kedia opened a new pull request, #17072:
URL: https://github.com/apache/pinot/pull/17072

   ## Description
   
   This change removes the deprecated `DEFAULT_SEGMENT_PUSH_TYPE` constant from 
`TableConfigBuilder.java` as indicated by the TODO comment. This is part of the 
ongoing effort to clean up deprecated code in preparation for a future major 
release.
   
   ## Changes Made
   
   1. Removed the constant definition:
   
   ```java
   private static final String DEFAULT_SEGMENT_PUSH_TYPE = "APPEND";
   ```
   
   2. Updated the field initialization to use the literal value:
   
   ```java
   @Deprecated
   private String _segmentPushType = "APPEND";
   ```
   
   3. Updated the `setSegmentPushType` method implementation to use the literal 
value:
   
   ```java
   public TableConfigBuilder setSegmentPushType(String segmentPushType) {
     if (REFRESH_SEGMENT_PUSH_TYPE.equalsIgnoreCase(segmentPushType)) {
       _segmentPushType = REFRESH_SEGMENT_PUSH_TYPE;
     } else {
       _segmentPushType = "APPEND";
     }
     return this;
   }
   ```
   
   4. Removed the associated TODO comment since the task is now complete.
   
   ##
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to