yashmayya commented on code in PR #17047:
URL: https://github.com/apache/pinot/pull/17047#discussion_r2466764237
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiStageEngineIntegrationTest.java:
##########
@@ -2109,11 +2100,41 @@ private JsonNode getQueryResultForDBTest(String column,
String tableName, @Nulla
return postQuery(query, headers);
}
+ private void setupDimensionTable() throws Exception {
+ // Set up the dimension table for NATURAL JOIN tests
+ Schema lookupTableSchema = createSchema(DIM_TABLE_SCHEMA_PATH);
+ addSchema(lookupTableSchema);
+ TableConfig tableConfig = createTableConfig(DIM_TABLE_TABLE_CONFIG_PATH);
+ TenantConfig tenantConfig = new TenantConfig(getBrokerTenant(),
getServerTenant(), null);
+ tableConfig.setTenantConfig(tenantConfig);
+ addTableConfig(tableConfig);
+ createAndUploadSegmentFromClasspath(tableConfig, lookupTableSchema,
DIM_TABLE_DATA_PATH, FileFormat.CSV,
+ DIM_NUMBER_OF_RECORDS, 60_000);
+ }
+
+ @Test
+ public void testNaturalJoinWithNoVirtualColumns()
Review Comment:
Are the test names inverted?
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiStageEngineIntegrationTest.java:
##########
@@ -2109,11 +2100,41 @@ private JsonNode getQueryResultForDBTest(String column,
String tableName, @Nulla
return postQuery(query, headers);
}
+ private void setupDimensionTable() throws Exception {
+ // Set up the dimension table for NATURAL JOIN tests
Review Comment:
```suggestion
// Set up the dimension table for JOIN tests
```
nit: even the lookup join test uses this, so it's not necessarily only for
natural joins.
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiStageEngineIntegrationTest.java:
##########
@@ -2109,11 +2100,41 @@ private JsonNode getQueryResultForDBTest(String column,
String tableName, @Nulla
return postQuery(query, headers);
}
+ private void setupDimensionTable() throws Exception {
+ // Set up the dimension table for NATURAL JOIN tests
+ Schema lookupTableSchema = createSchema(DIM_TABLE_SCHEMA_PATH);
+ addSchema(lookupTableSchema);
+ TableConfig tableConfig = createTableConfig(DIM_TABLE_TABLE_CONFIG_PATH);
+ TenantConfig tenantConfig = new TenantConfig(getBrokerTenant(),
getServerTenant(), null);
+ tableConfig.setTenantConfig(tenantConfig);
+ addTableConfig(tableConfig);
+ createAndUploadSegmentFromClasspath(tableConfig, lookupTableSchema,
DIM_TABLE_DATA_PATH, FileFormat.CSV,
+ DIM_NUMBER_OF_RECORDS, 60_000);
+ }
+
+ @Test
+ public void testNaturalJoinWithNoVirtualColumns()
+ throws Exception {
+ String query = "SELECT * FROM mytable a NATURAL JOIN daysOfWeek b
OPTION(excludeVirtualColumns=false) LIMIT 5";
Review Comment:
```suggestion
String query = "SET excludeVirtualColumns=false; SELECT * FROM mytable a
NATURAL JOIN daysOfWeek b LIMIT 5";
```
The `OPTION(...)` way of specifying query options has been deprecated for a
while, we use the `SET` statement instead -
https://docs.pinot.apache.org/users/user-guide-query/query-options#set-query-options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
