yashmayya commented on code in PR #17047:
URL: https://github.com/apache/pinot/pull/17047#discussion_r2457594690
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/QueryEnvironment.java:
##########
@@ -174,12 +175,23 @@ public QueryEnvironment(String database, TableCache
tableCache, @Nullable Worker
.build());
}
+ /**
+ * Checks if excludeVirtualColumns option is enabled in the current query
context.
+ */
+ private boolean isExcludeVirtualColumnsEnabled(Map<String, String> options) {
Review Comment:
nit: probably doesn't need to be a separate method here
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -736,6 +736,11 @@ public static class QueryOptionKey {
public static final String DROP_RESULTS = "dropResults";
+ // Exclude virtual columns (columns starting with '$') from table
schema
+ // This is typically used for NATURAL JOIN operations where virtual
columns
+ // should not participate in join condition matching
Review Comment:
nit: also add that it's only used in the MSE as of now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
