somandal commented on code in PR #16931:
URL: https://github.com/apache/pinot/pull/16931#discussion_r2408072676
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManagerConfig.java:
##########
@@ -252,6 +257,12 @@ public int getMaxParallelRefreshThreads() {
return _serverConfig.getProperty(MAX_PARALLEL_REFRESH_THREADS, 1);
}
+ @Override
+ public boolean isEnableSegmentRefreshAsynchronousHandling() {
Review Comment:
no, unfortunately this checks and initializes the refresh executor during
the init() call. there are may other configs that are updated in the same way
for this class, so I'd prefer if we take up a separate effort holistically go
through and make all of these configs updatable without restart.
Let me know if the above is okay for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
