9aman commented on code in PR #16931:
URL: https://github.com/apache/pinot/pull/16931#discussion_r2413224760
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/InstanceDataManager.java:
##########
@@ -169,6 +169,11 @@ void reloadSegments(String tableNameWithType, List<String>
segmentNames, boolean
*/
int getMaxParallelRefreshThreads();
+ /**
+ * Returns true if background processing for SEGMENT_REFRESH is enabled,
false otherwise
Review Comment:
Are there any guardrails in case
`public static final String MAX_PARALLEL_REFRESH_THREADS =
"max.parallel.refresh.threads";
`
is set to high value. That's one concern that I see.
Although, the same concern also applies to the number of parallel helix
message processing allowed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
