Jackie-Jiang commented on code in PR #17009:
URL: https://github.com/apache/pinot/pull/17009#discussion_r2430237623
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MailboxSendOperator.java:
##########
@@ -214,21 +214,28 @@ protected MseBlock getNextBlock() {
sendEos((MseBlock.Eos) block);
} else {
sendMseBlock(((MseBlock.Data) block));
+ checkTerminationAndSampleUsage();
}
- checkTerminationAndSampleUsage();
return block;
- } catch (QueryCancelledException e) {
- LOGGER.debug("Query was cancelled for opChain: {}", _context.getId());
- return SuccessMseBlock.INSTANCE;
- } catch (TerminationException e) {
- LOGGER.info("Query was terminated for opChain: {}", _context.getId(), e);
- return ErrorMseBlock.fromException(e);
- } catch (QueryException e) {
- return ErrorMseBlock.fromException(e);
} catch (RuntimeException e) {
- ErrorMseBlock errorBlock = ErrorMseBlock.fromException(e);
- try {
+ if (e instanceof QueryCancelledException) {
+ LOGGER.debug("Query was cancelled for opChain: {}", _context.getId());
+ return SuccessMseBlock.INSTANCE;
Review Comment:
Good ask. This is the existing behavior. Added a TODO to revisit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
