Copilot commented on code in PR #17009:
URL: https://github.com/apache/pinot/pull/17009#discussion_r2427576311
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineSecureGRPCServerIntegrationTest.java:
##########
@@ -35,6 +35,8 @@ public class OfflineSecureGRPCServerIntegrationTest extends
OfflineGRPCServerInt
@Override
protected void overrideServerConf(PinotConfiguration serverConf) {
+ super.overrideServerConf(serverConf);
+
serverConf.setProperty(Server.CONFIG_OF_GRPCTLS_SERVER_ENABLED, true);
Review Comment:
The call to `super.overrideServerConf(serverConf)` should be placed after
the existing configuration properties to maintain consistency with the existing
pattern and avoid potential configuration override conflicts.
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MailboxSendOperator.java:
##########
@@ -214,21 +214,28 @@ protected MseBlock getNextBlock() {
sendEos((MseBlock.Eos) block);
} else {
sendMseBlock(((MseBlock.Data) block));
+ checkTerminationAndSampleUsage();
Review Comment:
The line placement is incorrect. Line 217 shows the method call indented
incorrectly after the refactoring. The indentation should align with the
surrounding code structure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
