Jackie-Jiang commented on code in PR #16885:
URL: https://github.com/apache/pinot/pull/16885#discussion_r2377446634
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/ArrayCopyUtils.java:
##########
@@ -268,7 +268,9 @@ public static void copyToBoolean(String[] src, int[] dest,
int length) {
public static void copyToTimestamp(String[] src, long[] dest, int length) {
for (int i = 0; i < length; i++) {
- dest[i] = TimestampUtils.toMillisSinceEpoch(src[i]);
+ if (src[i] != null) {
Review Comment:
We don't do null handling in this util class, so I suggest keeping it
consistent with other methods. We can loop over the bitmap in
`CastTransformFunction`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
