Jackie-Jiang commented on code in PR #16885:
URL: https://github.com/apache/pinot/pull/16885#discussion_r2380028019
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CastTransformFunction.java:
##########
@@ -191,7 +194,19 @@ private long[] transformToTimestampValuesSV(ValueBlock
valueBlock) {
int length = valueBlock.getNumDocs();
initLongValuesSV(length);
String[] stringValues =
_transformFunction.transformToStringValuesSV(valueBlock);
- ArrayCopyUtils.copyToTimestamp(stringValues, _longValuesSV, length);
+ RoaringBitmap nullBitmap = _transformFunction.getNullBitmap(valueBlock);
Review Comment:
Should we check if null handling is enabled first?
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CastTransformFunction.java:
##########
@@ -191,7 +194,19 @@ private long[] transformToTimestampValuesSV(ValueBlock
valueBlock) {
int length = valueBlock.getNumDocs();
initLongValuesSV(length);
String[] stringValues =
_transformFunction.transformToStringValuesSV(valueBlock);
- ArrayCopyUtils.copyToTimestamp(stringValues, _longValuesSV, length);
+ RoaringBitmap nullBitmap = _transformFunction.getNullBitmap(valueBlock);
+ if (nullBitmap != null) {
Review Comment:
Do we need to check if it is empty? (not sure if empty one is returned as
`null`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
