Copilot commented on code in PR #17003:
URL: https://github.com/apache/pinot/pull/17003#discussion_r2425646757
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/dispatch/QueryDispatcher.java:
##########
@@ -168,6 +168,7 @@ public QueryResult submitAndReduce(RequestContext context,
DispatchableSubPlan d
submit(requestId, dispatchableSubPlan, timeoutMs, servers, queryOptions);
QueryResult result = runReducer(dispatchableSubPlan, queryOptions,
_mailboxService);
if (result.getProcessingException() != null) {
+ LOGGER.warn("Query result includes processing exceptions. Trying to
cancel the other opchains");
Review Comment:
The term 'opchains' appears to be a typo and should likely be 'op chains' or
'operation chains'.
```suggestion
LOGGER.warn("Query result includes processing exceptions. Trying to
cancel the other op chains");
```
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -1892,7 +1892,11 @@ public static class RewriterConstants {
*/
public static class MultiStageQueryRunner {
/**
- * Configuration for mailbox data block size
+ * Configuration for mailbox data block size.
+ *
+ * Ideally it should be in the order of a few MBs, to balance the
serialization/deserialization overhead and the
+ * number of messages to transfer. Values lower tha hundreds of KBs are
not recommended and may lead to excessive
Review Comment:
Corrected spelling of 'tha' to 'than'.
```suggestion
* number of messages to transfer. Values lower than hundreds of KBs are
not recommended and may lead to excessive
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
