gortiz commented on code in PR #17003:
URL: https://github.com/apache/pinot/pull/17003#discussion_r2427030593
##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/mailbox/MailboxServiceTest.java:
##########
@@ -80,7 +79,7 @@ public void setUpStats() {
_stats = new StatMap<>(MailboxSendOperator.StatKey.class);
}
- @Test
+ @Test(timeOut = 100000)
Review Comment:
My changes broke one of the tests, which never reached the termination
condition. As a result, GHA job was running for 3 hours and the log wasn't very
useful to understand what was going on. We should use the await version that
accepts a timeout (ie I changed some tests to use receiveMailLatch.await(10000,
TimeUnit.MILLISECONS)) but anyway having a timeout on tests would be great.
Before changing all this @Test, I asked chatgpt for a way to set a default
timeout for testng, but it wasn't able to tell me how. I guess it is another
reason to eventually move to JUnit 5 (or even 6, which was recently released!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
