Copilot commented on code in PR #17000:
URL: https://github.com/apache/pinot/pull/17000#discussion_r2421848141
##########
pinot-connectors/pinot-spark-3-connector/pom.xml:
##########
@@ -56,6 +56,12 @@
<includes>
<include>com.google.protobuf.**</include>
<include>com.google.common.**</include>
+ </includes>
+ </relocation>
+ <relocation>
+ <pattern>io</pattern>
+ <shadedPattern>${shadeBase}.io</shadedPattern>
Review Comment:
The relocation pattern 'io' is too broad and will shade all packages
starting with 'io', not just io.grpc. This should be 'io.grpc' to match the
specific include pattern and avoid unintended relocations of other io.*
packages.
```suggestion
<pattern>io.grpc</pattern>
<shadedPattern>${shadeBase}.io.grpc</shadedPattern>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
