gortiz commented on code in PR #17000:
URL: https://github.com/apache/pinot/pull/17000#discussion_r2425577725
##########
pinot-connectors/pinot-spark-3-connector/pom.xml:
##########
@@ -56,6 +56,12 @@
<includes>
<include>com.google.protobuf.**</include>
<include>com.google.common.**</include>
+ </includes>
+ </relocation>
+ <relocation>
+ <pattern>io</pattern>
+ <shadedPattern>${shadeBase}.io</shadedPattern>
Review Comment:
I think copilot has a point here. Are we sure just `io` is good enough? We
also need to remember that this shading also means users should also set
`-D${shadeBase}.io.grpc.netty.shaded.io.netty.tryReflectionSetAccessible=true`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
