Jackie-Jiang commented on code in PR #16922:
URL: https://github.com/apache/pinot/pull/16922#discussion_r2397301060
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/predicate/RegexpLikePredicateEvaluatorFactory.java:
##########
@@ -69,67 +60,36 @@ public static BaseRawValueBasedPredicateEvaluator
newRawValueBasedEvaluator(Rege
return new RawValueBasedRegexpLikePredicateEvaluator(regexpLikePredicate);
}
- private static final class DictIdBasedRegexpLikePredicateEvaluator
- extends BaseDictIdBasedRegexpLikePredicateEvaluator {
Review Comment:
I just realize this is extending
`BaseDictIdBasedRegexpLikePredicateEvaluator`, which is used to determine
whether inverted index can be applied. This means we should still keep this
implementation..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
