Jackie-Jiang commented on code in PR #16922:
URL: https://github.com/apache/pinot/pull/16922#discussion_r2393107134
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/predicate/RegexpLikePredicateEvaluatorFactory.java:
##########
@@ -122,14 +135,31 @@ private static final class
ScanBasedRegexpLikePredicateEvaluator extends BaseDic
// within the scope of a single thread.
final Matcher _matcher;
+ // _evaluatedIds: tracks which dictionary IDs have been evaluated
+ // _matchingIds: tracks which dictionary IDs match the regex pattern
+ final BitSet _evaluatedIds;
+ final BitSet _matchingIds;
+
public ScanBasedRegexpLikePredicateEvaluator(RegexpLikePredicate
regexpLikePredicate, Dictionary dictionary) {
super(regexpLikePredicate, dictionary);
_matcher = regexpLikePredicate.getPattern().matcher("");
+ _evaluatedIds = new BitSet();
Review Comment:
We want to pre-size the bit-set to avoid expending it while scanning values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
