Jackie-Jiang commented on code in PR #16899:
URL: https://github.com/apache/pinot/pull/16899#discussion_r2383706111
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/GrpcSendingMailbox.java:
##########
@@ -305,6 +313,16 @@ static List<ByteString> toByteStrings(List<ByteBuffer>
bytes, int maxByteStringS
return result;
}
+ @Override
+ public void close()
+ throws Exception {
+ if (!isTerminated()) {
+ LOGGER.debug("Closing gPRC mailbox without proper EOS message");
+ _closeAttempted = true;
+ _contentObserver.onError(Status.CANCELLED.asException());
Review Comment:
This might be the reason of the test failure. `onError()` could cause server
to error out without processing all the data blocks. Why do you want to send
cancellation when closing the sending mailbox? Closing the sending mailbox only
means its work is done right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
