deepthi912 commented on code in PR #16899:
URL: https://github.com/apache/pinot/pull/16899#discussion_r2380077644
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/exchange/BlockExchange.java:
##########
@@ -174,9 +174,15 @@ protected void sendBlock(SendingMailbox sendingMailbox,
MseBlock.Data block)
protected abstract void route(List<SendingMailbox> destinations,
MseBlock.Data block)
throws IOException, TimeoutException;
- // Called when the OpChain gracefully returns.
- // TODO: This is a no-op right now.
+ @Override
public void close() {
+ for (SendingMailbox sendingMailbox : _sendingMailboxes) {
+ try {
+ sendingMailbox.close();
+ } catch (Exception e) {
+ LOGGER.debug("Exception while cancelling mailbox: {}", sendingMailbox,
e);
Review Comment:
I feel like this can be a warn log if the resource is not closed rather than
a debug log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
