somandal commented on code in PR #16856:
URL: https://github.com/apache/pinot/pull/16856#discussion_r2382837557
##########
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java:
##########
@@ -240,6 +240,10 @@ public static class ControllerPeriodicTasksConf {
"controller.retentionManager.initialDelayInSeconds";
public static final String
OFFLINE_SEGMENT_INTERVAL_CHECKER_INITIAL_DELAY_IN_SECONDS =
"controller.offlineSegmentIntervalChecker.initialDelayInSeconds";
Review Comment:
Reusing `getSegmentLevelValidationIntervalInSeconds` makes sense to me, so
let's keep that. Let's also ensure we update OSS documentation on this config
for the task?
I would recommend just deprecating configs that include
`offlineSegmentIntervalChecker` in the name, and add new ones with the new task
name. Do this in a backward compatible way as I mentioned above so that we
don't break existing deployments.
I just want to avoid issues in the future when context on this rename is
lost, we can avoid user error. AFAIK we often mention in docs that you can use
task name to set up some of the configs, and that won't work unless we address
this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
