somandal commented on code in PR #16856:
URL: https://github.com/apache/pinot/pull/16856#discussion_r2379785014


##########
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java:
##########
@@ -240,6 +240,10 @@ public static class ControllerPeriodicTasksConf {
         "controller.retentionManager.initialDelayInSeconds";
     public static final String 
OFFLINE_SEGMENT_INTERVAL_CHECKER_INITIAL_DELAY_IN_SECONDS =
         "controller.offlineSegmentIntervalChecker.initialDelayInSeconds";

Review Comment:
   cc @Jackie-Jiang is there any recommendation for config backward 
compatibility when doing renames of periodic tasks etc?
   
   I was wondering if it would make sense to support naming the config with 
both the older and newer periodic task name, give preference to the newer 
config if present, and deprecate the older config name. any thoughts?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to