somandal commented on code in PR #16791:
URL: https://github.com/apache/pinot/pull/16791#discussion_r2356294759
##########
pinot-broker/src/main/java/org/apache/pinot/broker/routing/BrokerRoutingManager.java:
##########
@@ -143,8 +163,17 @@ public void init(HelixManager helixManager) {
_propertyStore = helixManager.getHelixPropertyStore();
}
+ private Object getRoutingTableBuildLock(String tableNameWithType) {
+ String rawTableName =
TableNameBuilder.extractRawTableName(tableNameWithType);
+ return _routingTableBuildLocks.computeIfAbsent(rawTableName, k -> new
Object());
+ }
+
+ private long getLastRoutingTableBuildStartTimeMs(String tableNameWithType) {
+ return _routingTableBuildStartTimeMs.computeIfAbsent(tableNameWithType, k
-> Long.MIN_VALUE);
+ }
+
@Override
- public synchronized void processClusterChange(ChangeType changeType) {
+ public void processClusterChange(ChangeType changeType) {
Review Comment:
not sure how keeping this synchronized will help? it'll just prevent
concurrent calls to this function, but is protected by the caller anyways? none
of the others are synchronized, right? can add a comment maybe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
