abhishekbafna commented on code in PR #16791:
URL: https://github.com/apache/pinot/pull/16791#discussion_r2338680089
##########
pinot-broker/src/main/java/org/apache/pinot/broker/routing/BrokerRoutingManager.java:
##########
@@ -100,6 +102,11 @@
* <li>{@link #getQueryTimeoutMs(String)}: Returns the table-level query
timeout in milliseconds for a table</li>
* </ul>
*
+ * LOCK ORDERING RULE: Always acquire locks in this order to prevent deadlocks:
+ * 1. _globalLock (read or write)
+ * 2. _routingTableBuildLocks (per logical table, where logical table is the
rawTableName)
Review Comment:
The `logical` could be confusing. Can we just mention it as raw table name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
