noob-se7en commented on code in PR #16811:
URL: https://github.com/apache/pinot/pull/16811#discussion_r2348356712
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -2689,18 +2689,8 @@ public void
repairSegmentsInErrorStateForPauselessConsumption(TableConfig tableC
// Find at least one server that should host this segment and is alive
Map<String, String> idealStateMap =
segmentToInstanceIdealStateMap.get(segmentName);
assert idealStateMap != null;
- String aliveServer = pickServerToReingest(idealStateMap.keySet());
- if (aliveServer == null) {
- LOGGER.warn("No alive server found to re-ingest segment: {} in
table: {}, skipping re-ingestion", segmentName,
- realtimeTableName);
- continue;
- }
-
- try {
- triggerReingestion(aliveServer, segmentName);
- LOGGER.info("Successfully triggered re-ingestion for segment: {} on
server: {}", segmentName, aliveServer);
- } catch (Exception e) {
- LOGGER.error("Failed to call reingestSegment for segment: {} on
server: {}", segmentName, aliveServer, e);
+ if (hasOnlineInstance(idealStateMap)) {
Review Comment:
This is already checked above I beleive?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
