xiangfu0 commented on code in PR #16811:
URL: https://github.com/apache/pinot/pull/16811#discussion_r2365692486
##########
pinot-controller/src/main/java/org/apache/pinot/controller/validation/RealtimeSegmentValidationManager.java:
##########
@@ -130,14 +130,13 @@ protected void processTable(String tableNameWithType,
Context context) {
LOGGER.info("Skipping segment-level validation for table: {}",
tableConfig.getTableName());
}
- boolean isPauselessConsumptionEnabled =
PauselessConsumptionUtils.isPauselessEnabled(tableConfig);
- if (isPauselessConsumptionEnabled) {
- // For pauseless tables without dedup or partial upsert, repair segments
in error state
-
_llcRealtimeSegmentManager.repairSegmentsInErrorStateForPauselessConsumption(tableConfig,
- context._repairErrorSegmentsForPartialUpsertOrDedup);
- } else if (_segmentAutoResetOnErrorAtValidation) {
- // Reset for pauseless tables is already handled in
repairSegmentsInErrorStateForPauselessConsumption method with
- // additional checks for pauseless consumption
+ // For realtime tables without dedup or partial upsert, repair segments in
error state
+ // This used to only work for pauseless table, but now extends the usage
to all tables
+
_llcRealtimeSegmentManager.repairSegmentsInErrorStateForPauselessConsumption(tableConfig,
+ context._repairErrorSegmentsForPartialUpsertOrDedup);
+ if (_segmentAutoResetOnErrorAtValidation) {
Review Comment:
good point, repurpose this
`repairSegmentsInErrorStateForPauselessConsumption` to
`repairSegmentsInErrorState` to fix all realtime segment error state
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
