rhodo commented on code in PR #16722:
URL: https://github.com/apache/pinot/pull/16722#discussion_r2319991487
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/relocation/SegmentRelocator.java:
##########
@@ -182,34 +183,46 @@ BlockingQueue<String> getWaitingQueue() {
return _waitingQueue;
}
- private void rebalanceTable(String tableNameWithType) {
+ @VisibleForTesting
+ void rebalanceTable(String tableNameWithType) {
TableConfig tableConfig =
_pinotHelixResourceManager.getTableConfig(tableNameWithType);
Preconditions.checkState(tableConfig != null, "Failed to find table config
for table: %s", tableNameWithType);
+ RebalanceConfig rebalanceConfig = new RebalanceConfig();
+
boolean relocate = false;
- if (TierConfigUtils.shouldRelocateToTiers(tableConfig)) {
- relocate = true;
- LOGGER.info("Relocating segments to tiers for table: {}",
tableNameWithType);
- }
if (tableConfig.getTableType() == TableType.REALTIME
&&
InstanceAssignmentConfigUtils.shouldRelocateCompletedSegments(tableConfig)) {
relocate = true;
LOGGER.info("Relocating COMPLETED segments for table: {}",
tableNameWithType);
}
+ if (TierConfigUtils.shouldRelocateToTiers(tableConfig)) {
+ relocate = true;
+ rebalanceConfig.setUpdateTargetTier(true);
+ LOGGER.info("Relocating segments to tiers for table: {}",
tableNameWithType);
+ } else {
+ List<SegmentZKMetadata> segmentsZKMetadata =
_pinotHelixResourceManager.getSegmentsZKMetadata(tableNameWithType);
Review Comment:
Yea, I think operator was under the impression that segment relocator will
do the job to relocate the segments. Actually in this case they were invoking
segment relocator via `task/schedule` api directly but realized it turns out to
be no-op, which is sort of confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
