xiangfu0 commented on code in PR #16745: URL: https://github.com/apache/pinot/pull/16745#discussion_r2324284058
########## docker/images/pinot/etc/jmx_prometheus_javaagent/configs/pinot.yml: ########## @@ -596,6 +596,34 @@ rules: - pattern: "\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"ServerMetrics\", name=\"pinot\\.server\\.grpc(.+)\"><>(\\w+)" name: "pinot_server_grpc$1_$2" cache: true + # Kafka Consumer Metrics with Scope-based Approach + # Consumer-level metrics (most aggregated, usually most reliable) +- pattern: "kafka\\.consumer<type=consumer-fetch-manager-metrics, client-id=([^,]+)_REALTIME-([^,]+)-(\\d+)><>(fetch-rate|fetch-latency-avg|fetch-throttle-time-avg|bytes-consumed-rate|records-consumed-rate|fetch-size-avg|fetch-size-max|records-per-request-avg|records-per-request-avg)" + name: "kafka_consumer_$4" + cache: true + labels: + table: "$1" + topic_name: "$2" + partition: "$3" + scope: "consumer" + # Topic-level metrics (includes topic information from MBean) +- pattern: "kafka\\.consumer<type=consumer-fetch-manager-metrics, client-id=(.+)_REALTIME-(.+)-(\\d+), topic=([^\"]+)><>(bytes-consumed-rate|records-consumed-rate|fetch-size-avg|fetch-size-max|records-per-request-avg)" Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
