Copilot commented on code in PR #16745: URL: https://github.com/apache/pinot/pull/16745#discussion_r2318729595
########## docker/images/pinot/etc/jmx_prometheus_javaagent/configs/server.yml: ########## @@ -85,3 +85,31 @@ rules: name: "pinot_$1_$2_$3" cache: true +# Kafka Consumer Metrics with Scope-based Approach +# Consumer-level metrics (most aggregated, usually most reliable) +- pattern: "kafka\\.consumer<type=consumer-fetch-manager-metrics, client-id=([^,]+)_REALTIME-([^,]+)-(\\d+)><>(fetch-rate|fetch-latency-avg|fetch-throttle-time-avg|bytes-consumed-rate|records-consumed-rate|fetch-size-avg|fetch-size-max|records-per-request-avg|records-per-request-avg)" Review Comment: The metric `records-per-request-avg` is duplicated in the regex pattern. Remove the duplicate occurrence. ```suggestion - pattern: "kafka\\.consumer<type=consumer-fetch-manager-metrics, client-id=([^,]+)_REALTIME-([^,]+)-(\\d+)><>(fetch-rate|fetch-latency-avg|fetch-throttle-time-avg|bytes-consumed-rate|records-consumed-rate|fetch-size-avg|fetch-size-max|records-per-request-avg)" ``` ########## docker/images/pinot/etc/jmx_prometheus_javaagent/configs/pinot.yml: ########## @@ -596,6 +596,34 @@ rules: - pattern: "\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"ServerMetrics\", name=\"pinot\\.server\\.grpc(.+)\"><>(\\w+)" name: "pinot_server_grpc$1_$2" cache: true + # Kafka Consumer Metrics with Scope-based Approach + # Consumer-level metrics (most aggregated, usually most reliable) +- pattern: "kafka\\.consumer<type=consumer-fetch-manager-metrics, client-id=([^,]+)_REALTIME-([^,]+)-(\\d+)><>(fetch-rate|fetch-latency-avg|fetch-throttle-time-avg|bytes-consumed-rate|records-consumed-rate|fetch-size-avg|fetch-size-max|records-per-request-avg|records-per-request-avg)" Review Comment: The metric `records-per-request-avg` is duplicated in the regex pattern. Remove the duplicate occurrence. ```suggestion - pattern: "kafka\\.consumer<type=consumer-fetch-manager-metrics, client-id=([^,]+)_REALTIME-([^,]+)-(\\d+)><>(fetch-rate|fetch-latency-avg|fetch-throttle-time-avg|bytes-consumed-rate|records-consumed-rate|fetch-size-avg|fetch-size-max|records-per-request-avg)" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
