tarun11Mavani commented on code in PR #16344:
URL: https://github.com/apache/pinot/pull/16344#discussion_r2306219865
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerGauge.java:
##########
@@ -128,7 +128,10 @@ public enum ServerGauge implements AbstractMetrics.Gauge {
STARTUP_STATUS_CHECK_IN_PROGRESS("state", true,
"Indicates whether the server startup status check is currently in
progress"),
CONSUMER_LOCK_WAIT_TIME_MS("milliseconds", false,
- "Indicates the time consumer spends while waiting on the consumer
lock.");
+ "Indicates the time consumer spends while waiting on the consumer
lock."),
+
+ // commit-time compaction gauge metrics
+ COMMIT_TIME_COMPACTION_RATIO_PERCENT("percentage", false, "Percentage of
rows removed during commit-time compaction");
Review Comment:
Since I am publishing as a gauge I have kept it in the ServerGauge. I feel
keeping it as gauge instead of meter is better as it's not a count metric.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
