tarun11Mavani commented on code in PR #16344:
URL: https://github.com/apache/pinot/pull/16344#discussion_r2306196327
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/converter/stats/RealtimeSegmentSegmentCreationDataSource.java:
##########
@@ -32,17 +33,26 @@
*/
public class RealtimeSegmentSegmentCreationDataSource implements
SegmentCreationDataSource {
private final MutableSegment _mutableSegment;
- private final PinotSegmentRecordReader _recordReader;
+ private final RecordReader _recordReader;
+ private final int[] _sortedDocIds;
public RealtimeSegmentSegmentCreationDataSource(MutableSegment
mutableSegment,
PinotSegmentRecordReader recordReader) {
_mutableSegment = mutableSegment;
_recordReader = recordReader;
+ _sortedDocIds = recordReader.getSortedDocIds();
+ }
+
+ public RealtimeSegmentSegmentCreationDataSource(MutableSegment
mutableSegment, RecordReader recordReader,
Review Comment:
yes. But since I am not introducing this class in this PR, I will keep it as
it to make it easier to cherry-pick.
Don't want to introduce refactoring changes related to this in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
