Jackie-Jiang commented on code in PR #16583:
URL: https://github.com/apache/pinot/pull/16583#discussion_r2305045043
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/docidsets/OrDocIdSet.java:
##########
@@ -53,10 +54,16 @@ public final class OrDocIdSet implements BlockDocIdSet {
private final int _numDocs;
private List<BlockDocIdSet> _docIdSets;
private volatile long _numEntriesScannedInFilter = 0L;
+ private boolean _isAlwaysFalse;
Review Comment:
If we already know it is always false, we should directly crease
`EmptyDocIdSet.getInstance()` instead. Similar for other `BlockDocIdSet`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
