tarun11Mavani commented on code in PR #16583:
URL: https://github.com/apache/pinot/pull/16583#discussion_r2284835936
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/dociditerators/RangelessBitmapDocIdIterator.java:
##########
@@ -56,4 +56,8 @@ public int advance(int targetDocId) {
_docIdIterator.advanceIfNeeded(targetDocId);
return next();
}
+
+ public boolean hasNext() {
Review Comment:
Is this needed for this change?
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/docidsets/BitmapDocIdSet.java:
##########
@@ -43,4 +46,12 @@ public BitmapDocIdIterator iterator() {
public long getNumEntriesScannedInFilter() {
return 0L;
}
+
+ @Override
+ public BlockDocIdSet getOptimizedDocIdSet() {
+ if (_bitmap != null && _bitmap.isEmpty()) {
Review Comment:
Is it safe to assume the matching docs are zero if _bitmap == null. If yes,
we can change this condition.
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/docidsets/AndDocIdSet.java:
##########
@@ -104,6 +112,9 @@ public BlockDocIdIterator iterator() {
_docIdSets = null;
_numEntriesScannedInFilter = numEntriesScannedForNonScanBasedDocIdSets;
_scanBasedDocIdSets.set(scanBasedDocIdSets);
+ if (_isAlwaysFalse) {
Review Comment:
Can we move this up for early exit? Or we need to execute the above section
for stats collections?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
