gortiz commented on code in PR #16258: URL: https://github.com/apache/pinot/pull/16258#discussion_r2222707661
########## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/function/ToDateTimeUdf.java: ########## @@ -0,0 +1,74 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.query.runtime.function; + +import com.google.auto.service.AutoService; +import java.util.Map; +import java.util.Set; +import org.apache.pinot.common.function.TransformFunctionType; +import org.apache.pinot.common.function.scalar.DateTimeFunctions; +import org.apache.pinot.core.operator.transform.function.TransformFunction; +import org.apache.pinot.core.udf.Udf; +import org.apache.pinot.core.udf.UdfExample; +import org.apache.pinot.core.udf.UdfExampleBuilder; +import org.apache.pinot.core.udf.UdfParameter; +import org.apache.pinot.core.udf.UdfSignature; +import org.apache.pinot.spi.data.FieldSpec; + + +@AutoService(Udf.class) +public class ToDateTimeUdf extends Udf.FromAnnotatedMethod { + + public ToDateTimeUdf() throws NoSuchMethodException { + super(DateTimeFunctions.class, "toDateTime", long.class, String.class); + } + + @Override + public String getDescription() { + return "Converts epoch millis to a DateTime string represented by the given pattern. " + + "Optionally, a timezone can be provided."; + } + + @Override + public Map<UdfSignature, Set<UdfExample>> getExamples() { + return UdfExampleBuilder.forSignature( + UdfSignature.of( + UdfParameter.of("mills", FieldSpec.DataType.LONG) + .withDescription("A long value representing epoch millis, " + + "e.g., 1577836800000L for 2020-01-01T00:00:00Z"), + UdfParameter.of("format", FieldSpec.DataType.STRING) + .withDescription("A string literal representing the date format, " + + "e.g., 'yyyy-MM-dd'T'HH:mm:ss'Z' or 'yyyy-MM-dd'") + .asLiteralOnly(), + UdfParameter.result(FieldSpec.DataType.STRING) // Return type is single value STRING + )) + .addExample("UTC ISO8601", 1577836800000L, "yyyy-MM-dd'T'HH:mm:ss'Z'", "2020-01-01T00:00:00Z") + .addExample("Date only", 1577836800000L, "yyyy-MM-dd", "2020-01-01") Review Comment: Fixed why? Aren't they correct? They were basically generated by copilot 😆 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
