bziobrowski commented on code in PR #16258: URL: https://github.com/apache/pinot/pull/16258#discussion_r2222527551
########## pinot-udf-test/src/main/java/org/apache/pinot/udf/test/scenarios/ExpressionTransformerTestScenario.java: ########## @@ -0,0 +1,79 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.udf.test.scenarios; + +import com.google.auto.service.AutoService; +import java.util.HashMap; +import java.util.Map; +import org.apache.pinot.core.udf.Udf; +import org.apache.pinot.core.udf.UdfExample; +import org.apache.pinot.core.udf.UdfSignature; +import org.apache.pinot.segment.local.function.FunctionEvaluator; +import org.apache.pinot.segment.local.function.FunctionEvaluatorFactory; +import org.apache.pinot.spi.data.readers.GenericRow; +import org.apache.pinot.udf.test.PinotFunctionEnvGenerator; +import org.apache.pinot.udf.test.UdfExampleResult; +import org.apache.pinot.udf.test.UdfTestCluster; +import org.apache.pinot.udf.test.UdfTestScenario; + + +/// A test scenario where the UDF is executed as an ingestion time transformer. This scenario doesn't actually use +/// a cluster but instead uses the [FunctionEvaluatorFactory] to create an evaluator for the UDF and +/// evaluate it directly on the [GenericRow] objects generated by the [PinotFunctionEnvGenerator]. +public class ExpressionTransformerTestScenario implements UdfTestScenario { + + @Override + public String getTitle() { + return "Ingestion time transformer"; + } + + @Override + public String getDescription() { Review Comment: nit: TODOs left in this and other classes in the same package. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
