gortiz commented on PR #16210: URL: https://github.com/apache/pinot/pull/16210#issuecomment-3089040120
After fighting with tests for a while, it is clear to me that SegmentProcessorAvroUtils logic is bound to the current usages (mostly tests, but also FlinkSegmentWriter). Therefore, I don't think I can use this code in https://github.com/apache/pinot/pull/16258, so I'm going to close this PR. The main incompatibility is that SegmentProcessorAvroUtils assumes the types used in the received generic rows are the stored types (i.e., booleans are stored as int), while #16258 prefers to use booleans. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
