gortiz commented on code in PR #16210:
URL: https://github.com/apache/pinot/pull/16210#discussion_r2200773585
##########
pinot-core/src/main/java/org/apache/pinot/core/util/SegmentProcessorAvroUtils.java:
##########
@@ -83,45 +88,90 @@ public static Schema
convertPinotSchemaToAvroSchema(org.apache.pinot.spi.data.Sc
for (FieldSpec fieldSpec : orderedFieldSpecs) {
String name = fieldSpec.getName();
DataType storedType = fieldSpec.getDataType().getStoredType();
+
+ SchemaBuilder.BaseFieldTypeBuilder<Schema> type;
+ if (fieldSpec.isNullable()) {
+ type = fieldAssembler.name(name).type().nullable();
+ } else {
+ type = fieldAssembler.name(name).type();
+ }
+
+ String logicalType = "pinot." +
fieldSpec.getDataType().toString().toLowerCase(Locale.US);
if (fieldSpec.isSingleValueField()) {
switch (storedType) {
case INT:
- fieldAssembler =
fieldAssembler.name(name).type().intType().noDefault();
+ fieldAssembler = type.intBuilder()
Review Comment:
Probably not. We can discuss whether adding the local type is a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
