rhodo commented on code in PR #16342:
URL: https://github.com/apache/pinot/pull/16342#discussion_r2205984106
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##########
@@ -962,6 +957,7 @@ protected File
downloadSegmentFromDeepStore(SegmentZKMetadata zkMetadata)
+ "queue-length={}).", segmentName, System.currentTimeMillis()
- startTime,
segmentDownloadThrottler.getQueueLength());
}
+ _serverMetrics.addValueToTableGauge(_tableNameWithType,
ServerGauge.SEGMENT_TABLE_DOWNLOAD_COUNT, 1);
Review Comment:
yea actually I don't know why we deprecate that in the first place, It is
common to use inc()/dec() api with gauge IMO. but keeping
_numSegmentsAcquiredDownloadSemaphore also is not a unacceptable burden, I can
stick with that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
