somandal commented on code in PR #16342:
URL: https://github.com/apache/pinot/pull/16342#discussion_r2205979510
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##########
@@ -997,10 +993,9 @@ protected File
downloadSegmentFromDeepStore(SegmentZKMetadata zkMetadata)
FileUtils.deleteQuietly(tempRootDir);
}
} finally {
+ _serverMetrics.addValueToTableGauge(_tableNameWithType,
ServerGauge.SEGMENT_TABLE_DOWNLOAD_COUNT, -1);
Review Comment:
nit: just wondering if it might make sense to decrement after releasing like
before? should be fine to keep this as well though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
