abhishekbafna commented on code in PR #16249:
URL: https://github.com/apache/pinot/pull/16249#discussion_r2204618568
##########
pinot-minion/src/main/java/org/apache/pinot/minion/MinionConf.java:
##########
@@ -31,6 +31,13 @@ public class MinionConf extends PinotConfiguration {
public static final String MINION_TASK_PROGRESS_MANAGER_CLASS =
"pinot.minion.taskProgressManager.class";
public static final int DEFAULT_END_REPLACE_SEGMENTS_SOCKET_TIMEOUT_MS = 10
* 60 * 1000; // 10 mins
+ /**
+ * The number of threads to use for downloading segments from the deepstore.
+ * This is a global setting that applies to all tasks of
BaseMultipleSegmentsConversionExecutor class.
Review Comment:
It should not be the case. As the default value for
`DEFAULT_SEGMENT_DOWNLOAD_PARALLELISM = 1` config is set to 1 and it can not be
interpreted that only 1 segment download would happen across the tasks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
