abhishekbafna commented on PR #16249: URL: https://github.com/apache/pinot/pull/16249#issuecomment-3049701855
> LGTM other than few small changes. I think we should also ensure a test case goes through parallel download path (with more than 1 segment) and share performance results of parallel download Modified existing test cases to go down the parallel download path. ``` 22:34:24.943 INFO [BaseMultipleSegmentsConversionExecutor] [TaskStateModelFactory-task_thread-0] Start executing RealtimeToOfflineSegmentsTask on table: myTable2_REALTIME, input segments: myTable2__0__5__20250708T1704Z,myTable2__1__5__20250708T1704Z with downloadURLs: http://localhost:20000/segments/myTable2/myTable2__0__5__20250708T1704Z,http://localhost:20000/segments/myTable2/myTable2__1__5__20250708T1704Z, uploadURL: http://localhost:20000/segments, thread pool size:2 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
