gortiz commented on code in PR #16142:
URL: https://github.com/apache/pinot/pull/16142#discussion_r2200891308
##########
pinot-core/src/main/java/org/apache/pinot/core/accounting/PerQueryCPUMemAccountantFactory.java:
##########
@@ -106,6 +107,8 @@ public static class PerQueryCPUMemResourceUsageAccountant
implements ThreadResou
protected final HashMap<String, Long> _finishedTaskCPUStatsAggregator =
new HashMap<>();
protected final HashMap<String, Long> _finishedTaskMemStatsAggregator =
new HashMap<>();
+ protected final ConcurrentHashMap<String, QueryCancelCallback>
_queryCancelCallbacks = new ConcurrentHashMap<>();
Review Comment:
Well, the good thing is that each entry is very cheap. I had issues in the
past with the map we keep to return stats because I was keeping a reference to
the mse operators, which can be huge. Yours literally only references the
OpChainScheduler and the query id.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
