gortiz commented on code in PR #16142:
URL: https://github.com/apache/pinot/pull/16142#discussion_r2200204526


##########
pinot-core/src/main/java/org/apache/pinot/core/accounting/PerQueryCPUMemAccountantFactory.java:
##########
@@ -254,6 +268,15 @@ public boolean throttleQuerySubmission() {
       return getWatcherTask().getHeapUsageBytes() > 
getWatcherTask().getQueryMonitorConfig().getAlarmingLevel();
     }
 
+    @Override
+    public void registerQueryCancelCallback(String queryId, MseCancelCallback 
callback) {
+      _queryCancelCallbacks.put(queryId, callback);
+    }
+
+    public MseCancelCallback getQueryCancelCallback(String queryId) {

Review Comment:
   This should be marked as nullable



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to