gortiz commented on code in PR #16258:
URL: https://github.com/apache/pinot/pull/16258#discussion_r2200808655
##########
pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTest.java:
##########
@@ -637,12 +637,26 @@ protected boolean injectTombstones() {
return false;
}
- protected void createAndUploadSegmentFromFile(TableConfig tableConfig,
Schema schema, String dataFilePath,
+ protected void createAndUploadSegmentFromClasspath(TableConfig tableConfig,
Schema schema, String dataFilePath,
FileFormat fileFormat, long expectedNoOfDocs, long timeoutMs) throws
Exception {
URL dataPathUrl = getClass().getClassLoader().getResource(dataFilePath);
assert dataPathUrl != null;
File file = new File(dataPathUrl.getFile());
+ createAndUploadSegmentFromFile(tableConfig, schema, file, fileFormat,
expectedNoOfDocs, timeoutMs);
+ }
+
+ /// @deprecated use createAndUploadSegmentFromClasspath instead, given what
this class does is to look for
+ /// dataFilePath on the classpath
+ @Deprecated
+ protected void createAndUploadSegmentFromFile(TableConfig tableConfig,
Schema schema, String dataFilePath,
+ FileFormat fileFormat, long expectedNoOfDocs, long timeoutMs) throws
Exception {
+ createAndUploadSegmentFromClasspath(tableConfig, schema, dataFilePath,
fileFormat, expectedNoOfDocs, timeoutMs);
+ }
+
+ protected void createAndUploadSegmentFromFile(TableConfig tableConfig,
Schema schema, File file,
Review Comment:
I need this new method to upload files that are created on the fly instead
of being stored in the classpath as static examples
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
