gortiz commented on code in PR #16258:
URL: https://github.com/apache/pinot/pull/16258#discussion_r2200810824


##########
pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTest.java:
##########
@@ -637,12 +637,26 @@ protected boolean injectTombstones() {
     return false;
   }
 
-  protected void createAndUploadSegmentFromFile(TableConfig tableConfig, 
Schema schema, String dataFilePath,
+  protected void createAndUploadSegmentFromClasspath(TableConfig tableConfig, 
Schema schema, String dataFilePath,

Review Comment:
   I renamed this method because the older one (which I keep just to not break 
compatibility) incorrectly looked like it could be used to ingest any file, 
when in fact the file must be on the classpath



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to