somandal commented on code in PR #16002:
URL: https://github.com/apache/pinot/pull/16002#discussion_r2182934378
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/creator/IndexCreationContext.java:
##########
@@ -308,14 +323,29 @@ final class Common implements IndexCreationContext {
private final boolean _realtimeConversion;
private final File _consumerDir;
private final int[] _immutableToMutableIdMap;
+ private final String _tableNameWithType;
+ @Deprecated
Review Comment:
done, marked it as private based on @gortiz's recommendation as well so that
in the future we don't have compatibility failures
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/creator/IndexCreationContext.java:
##########
@@ -266,12 +271,22 @@ public Builder withImmutableToMutableIdMap(int[]
immutableToMutableIdMap) {
return this;
}
+ public Builder withTableNameWithType(@Nullable String tableNameWithType) {
+ _tableNameWithType = tableNameWithType;
+ return this;
+ }
+
+ public Builder withTableNameWithType(@Nullable TableConfig tableConfig) {
Review Comment:
done - removed and updated the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
