Jackie-Jiang commented on code in PR #16002:
URL: https://github.com/apache/pinot/pull/16002#discussion_r2181183713
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/creator/IndexCreationContext.java:
##########
@@ -308,14 +323,29 @@ final class Common implements IndexCreationContext {
private final boolean _realtimeConversion;
private final File _consumerDir;
private final int[] _immutableToMutableIdMap;
+ private final String _tableNameWithType;
+ @Deprecated
Review Comment:
We don't need to handle backward compatible here since this is an inner class
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/creator/IndexCreationContext.java:
##########
@@ -266,12 +271,22 @@ public Builder withImmutableToMutableIdMap(int[]
immutableToMutableIdMap) {
return this;
}
+ public Builder withTableNameWithType(@Nullable String tableNameWithType) {
+ _tableNameWithType = tableNameWithType;
+ return this;
+ }
+
+ public Builder withTableNameWithType(@Nullable TableConfig tableConfig) {
Review Comment:
It is a little bit strange to pass `TableConfig` into
`withTableNameWithType()`. Can you take a look at #16267 and see if the logic
can be simplified with it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
