Jackie-Jiang commented on code in PR #16241:
URL: https://github.com/apache/pinot/pull/16241#discussion_r2181014289
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -257,6 +257,9 @@ public static class Instance {
public static final String
CONFIG_OF_MULTI_STAGE_ENGINE_MAX_SERVER_QUERY_HARDLIMIT_FACTOR =
"pinot.beta.multistage.engine.max.server.query.threads.hardlimit.factor";
public static final String
DEFAULT_MULTI_STAGE_ENGINE_MAX_SERVER_QUERY_HARDLIMIT_FACTOR = "4";
+ public static final String CONFIG_OF_QUERY_THROTTLING_LOG_ONLY_ENABLED =
Review Comment:
My concern is that we cannot really control broker side and server side
behavior independently (similar to why we added server side limit in #16080).
I'd suggest adding
`pinot.broker.mse.max.server.query.threads.exceed.strategy` on broker and
`pinot.server.query.executor.mse.max.execution.threads.exceed.strategy`
separately and when it is configured as `log`, we log only. In the future we
can extend them to support fail on broker or wait on server
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
