satwik-pachigolla commented on code in PR #16241: URL: https://github.com/apache/pinot/pull/16241#discussion_r2178089233
########## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ########## @@ -257,6 +257,9 @@ public static class Instance { public static final String CONFIG_OF_MULTI_STAGE_ENGINE_MAX_SERVER_QUERY_HARDLIMIT_FACTOR = "pinot.beta.multistage.engine.max.server.query.threads.hardlimit.factor"; public static final String DEFAULT_MULTI_STAGE_ENGINE_MAX_SERVER_QUERY_HARDLIMIT_FACTOR = "4"; + public static final String CONFIG_OF_QUERY_THROTTLING_LOG_ONLY_ENABLED = Review Comment: This is used with both the broker and server configs so the enum modes wouldn't be the same between the two. The broker waits when throttling, while the servers instantly reject. I followed the same pattern as other instance configs such as `pinot.multistage.engine.enabled` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org