Jackie-Jiang commented on code in PR #16113:
URL: https://github.com/apache/pinot/pull/16113#discussion_r2178571033
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -933,6 +933,11 @@ public static class Server {
public static final String CONFIG_OF_RELOAD_CONSUMING_SEGMENT =
INSTANCE_DATA_MANAGER_CONFIG_PREFIX + "." + RELOAD_CONSUMING_SEGMENT;
public static final boolean DEFAULT_RELOAD_CONSUMING_SEGMENT = true;
+ public static final String
REALTIME_COMPLEX_CONFIG_SKIP_ORIGINAL_FIELD_IN_UNNEST =
+ "realtime.complex.config.skipOriginalFieldInUnnest";
Review Comment:
Why is this related to realtime?
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/ingestion/ComplexTypeConfig.java:
##########
@@ -48,15 +48,27 @@ public enum CollectionNotUnnestedToJson {
@JsonPropertyDescription("Map of <prefix, replacement> so matching fields
are renamed to start with the replacement")
private final Map<String, String> _prefixesToRename;
+ @JsonPropertyDescription("Skip original fields in unnest")
+ private boolean _skipOriginalFieldInUnnest;
Review Comment:
I feel `removeUnnestedFields` is more specific
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java:
##########
@@ -958,4 +960,19 @@ private boolean isEnforceConsumptionInOrder() {
StreamIngestionConfig streamIngestionConfig = getStreamIngestionConfig();
return streamIngestionConfig != null &&
streamIngestionConfig.isEnforceConsumptionInOrder();
}
+
+ /**
+ * Sets the skipOriginalFieldInUnnest field using server level config if
table level config is false.
+ */
+ private void setSkipOriginalFieldInUnnest(TableConfig tableConfig) {
Review Comment:
Do not modify the table config because it is cached and reused
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
