rohityadav1993 commented on code in PR #16113:
URL: https://github.com/apache/pinot/pull/16113#discussion_r2162211709
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/ingestion/ComplexTypeConfig.java:
##########
@@ -48,15 +48,27 @@ public enum CollectionNotUnnestedToJson {
@JsonPropertyDescription("Map of <prefix, replacement> so matching fields
are renamed to start with the replacement")
private final Map<String, String> _prefixesToRename;
+ @JsonPropertyDescription("Whether to retain original fields in unnest")
+ private boolean _retainOriginalFieldInUnnest;
Review Comment:
We should avoid changing the behaviour again as it will lead to ingestion
time incorrectness for existing users.
Can rename to _skipOriginalFieldInUnnest, which will defualt to false. Also,
add another server level config which can be preferred if
_skipOriginalFieldInUnnest is false/unset. This way we can configure for the
cluster at once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
